Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When re-opening a ResumableBidiRPC set _request_queue_generator to None. #7548

Merged
merged 1 commit into from
Mar 22, 2019
Merged

When re-opening a ResumableBidiRPC set _request_queue_generator to None. #7548

merged 1 commit into from
Mar 22, 2019

Conversation

crwilcox
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 22, 2019
@crwilcox crwilcox requested review from frankyn and tseaver March 22, 2019 22:45
@crwilcox
Copy link
Contributor Author

The instance member is internal and a _ was missed here.

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 22, 2019
frankyn
frankyn approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, with a note that this variable is a no-op as far as we can tell.

@crwilcox crwilcox merged commit 0c59689 into googleapis:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crwilcox @frankyn @googlebot @yoshi-kokoro